Skip to content

[https://nvbugs/5973199][fix] unwaive TestNemotronSuperV3::test_accuracy[nvfp4-4-attn_dp_on-trtllm]#13188

Open
tcherckez-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
tcherckez-nvidia:unwaive-5973199
Open

[https://nvbugs/5973199][fix] unwaive TestNemotronSuperV3::test_accuracy[nvfp4-4-attn_dp_on-trtllm]#13188
tcherckez-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
tcherckez-nvidia:unwaive-5973199

Conversation

@tcherckez-nvidia
Copy link
Copy Markdown
Collaborator

@tcherckez-nvidia tcherckez-nvidia commented Apr 19, 2026 •
edited by coderabbitai Bot
Loading

…

Summary by CodeRabbit

  • Tests
    • Removed a previously waived test skip entry, allowing the associated test to run.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@tcherckez-nvidia
Copy link
Copy Markdown
Collaborator Author

tcherckez-nvidia commented Apr 19, 2026

/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 93d20a5d-c3ee-435a-817e-1f6afdce0c47

📥 Commits

Reviewing files that changed from the base of the PR and between fc9d130 and f1abb7b.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
📝 Walkthrough

Walkthrough

A single skip entry was removed from the test waives list file. The entry corresponded to a specific test case for the Nemotron model with nvfp4-4 quantization and attention distributed parallelism, referencing a resolved issue.

Changes

Cohort / File(s) Summary
Test Configuration
tests/integration/test_lists/waives.txt		 Removed one skip entry for accuracy/test_llm_api_autodeploy.py::TestNemotronSuperV3::test_accuracy[nvfp4-4-attn_dp_on-trtllm].

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template structure with no meaningful content; required sections like Description and Test Coverage are empty or unfilled. Add a Description section explaining why the skip waiver is being removed and a Test Coverage section confirming the test now passes without being skipped.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing a skip waiver for a specific test case, and directly references the NVBugs issue being addressed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 19, 2026

PR_Github #44183 [ run ] triggered by Bot. Commit: f1abb7b Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 19, 2026

PR_Github #44183 [ run ] completed with state SUCCESS. Commit: f1abb7b
/LLM/main/L0_MergeRequest_PR pipeline #34610 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@tcherckez-nvidia
Copy link
Copy Markdown
Collaborator Author

tcherckez-nvidia commented Apr 20, 2026

/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1"

@tcherckez-nvidia tcherckez-nvidia enabled auto-merge (squash) April 20, 2026 05:02
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 20, 2026

PR_Github #44300 [ run ] triggered by Bot. Commit: f1abb7b Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 20, 2026

PR_Github #44300 [ run ] completed with state FAILURE. Commit: f1abb7b
/LLM/main/L0_MergeRequest_PR pipeline #34721 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@tcherckez-nvidia
Copy link
Copy Markdown
Collaborator Author

tcherckez-nvidia commented Apr 20, 2026

/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 20, 2026

PR_Github #44331 [ run ] triggered by Bot. Commit: d9376db Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 20, 2026

PR_Github #44331 [ run ] completed with state FAILURE. Commit: d9376db
/LLM/main/L0_MergeRequest_PR pipeline #34749 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@tcherckez-nvidia
[https://nvbugs/5973199][fix] unwaive TestNemotronSuperV3::test_accur…
e997bdb 
…acy[nvfp4-4-attn_dp_on-trtllm]

Signed-off-by: Tal Cherckez <127761168+tcherckez-nvidia@users.noreply.github.com>
@tcherckez-nvidia
Copy link
Copy Markdown
Collaborator Author

tcherckez-nvidia commented Apr 23, 2026

/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tcherckez-nvidia tcherckez-nvidia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tcherckez-nvidia @tensorrt-cicd